wombatu-kun commented on code in PR #18787:
URL: https://github.com/apache/iceberg/pull/18787#discussion_r4477071085
##########
core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java:
##########
@@ -49,7 +49,7 @@ public abstract class PartitionStatsHandlerTestBase extends
PartitionStatisticsT
public abstract FileFormat format();
@Parameters(name = "formatVersion = {0}")
- protected static List<Integer> formatVersions() {
+ protected static List<Integer> formatVersions() throws Exception {
Review Comment:
nit: `formatVersions()` doesn't need the new `throws Exception`, and
`tableWithTwoPartitions`/`tableWithUnevenPartitions` in
`PartitionStatisticsScanTestBase` still only throw `IOException`. Were these
signature changes intended, or can they be reverted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
