Shruthirdy opened a new pull request, #2424: URL: https://github.com/apache/iceberg-go/pull/2424
Closes #2423. When `describe` is run without the `table`/`namespace` keyword and neither a namespace nor a table matches, the fallback error wrapped `ErrNoSuchNamespace`, even when the parent namespace existed. The fallback is only reached after `LoadTable` has returned `ErrNoSuchTable`, so it now wraps `ErrNoSuchTable`. The identifier is also printed with dots, not as a slice. Before: ``` $ iceberg describe demo.test namespace does not exist: table or namespace does not exist: [demo test] ``` After: ``` $ iceberg describe demo.test table does not exist: no table or namespace named demo.test ``` `describe table ...` and `describe namespace ...` are unchanged. ### Testing - Adds `cmd/iceberg/describe_test.go` (`describe` had no tests). It checks that `describe demo.test` exits with code 1 and returns `ErrNoSuchTable`, not `ErrNoSuchNamespace`, with the name shown as `demo.test`. The test fails without the fix. - `go test ./cmd/iceberg/` passes. - Checked manually against a SQL catalog, including a nested namespace (`my.db`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
