mxm commented on code in PR #18717:
URL: https://github.com/apache/iceberg/pull/18717#discussion_r4480454213
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPKIndex.java:
##########
@@ -256,6 +268,25 @@ private void applyBufferedRows() throws Exception {
bufferedRows.clear();
}
+ private void removeFromIndex(DVPosition removed) throws Exception {
Review Comment:
Yes. I also realized that we're leaking the generation id. In an earlier
design it wasn't safe to evict the generation id because of pending resolves.
This no longer holds and we can clear it, see
https://github.com/apache/iceberg/pull/18717/commits/5afd871b715ebb0b104c707dcd533689c072ac03.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
