rambleraptor commented on code in PR #140:
URL:
https://github.com/apache/terraform-provider-iceberg/pull/140#discussion_r4484511824
##########
internal/provider/table_tfschema.go:
##########
@@ -32,6 +32,12 @@ func tableSchemaResourceAttributes()
map[string]rscschema.Attribute {
Optional: true,
Computed: true,
},
+ "identifier_field_ids": rscschema.ListAttribute{
Review Comment:
Shouldn't this be a set?
##########
internal/provider/table_tfschema.go:
##########
@@ -32,6 +32,12 @@ func tableSchemaResourceAttributes()
map[string]rscschema.Attribute {
Optional: true,
Computed: true,
},
+ "identifier_field_ids": rscschema.ListAttribute{
Review Comment:
We won't always know the identifier fields IDs ahead of time, which makes
this challenging. We will know the field names, so that might have to be the
way we do this.
##########
internal/provider/table_tfschema.go:
##########
@@ -32,6 +32,12 @@ func tableSchemaResourceAttributes()
map[string]rscschema.Attribute {
Optional: true,
Computed: true,
},
+ "identifier_field_ids": rscschema.ListAttribute{
Review Comment:
This will need to be added to docs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
