adityaksolves commented on PR #18325: URL: https://github.com/apache/iceberg/pull/18325#issuecomment-6661495734
@Fokko @nastra Could one of you please review this PR when you have time? It allows promoting an unknown (Spark VOID) column to a primitive type in TypeUtil.isPromotionAllowed, which fixes ALTER TABLE ... ALTER COLUMN ... TYPE failing on v3 VOID columns (#18305). The v3 spec permits unknown to be promoted to any primitive type, and since the column holds only nulls the evolution is safe. Status: rebased on latest main, CI green (41/41), with tests in TestTypeUtil, TestSchemaUpdate and TestAlterTable for Spark 3.5/4.0/4.1/4.2. The overlapping PR #16528 was closed in favor of this one, so there's no duplicate effort pending. Happy to address any feedback. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
