adutra commented on code in PR #14590:
URL: https://github.com/apache/iceberg/pull/14590#discussion_r4480486168
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##########
@@ -54,7 +54,7 @@ public class AuthSessionCache implements AutoCloseable {
public AuthSessionCache(String name, Duration sessionTimeout) {
this(
sessionTimeout,
- ThreadPools.newExitingWorkerPool(name + "-auth-session-evict", 1),
+ ThreadPools.newFixedThreadPool(name + "-auth-session-evict", 1),
Review Comment:
See this thread for the original discussion:
https://github.com/apache/iceberg/pull/11844#discussion_r1910677023
TBH my opinion is that we should have used to common pool here, or maybe
just `Runnable::run`.
If this executor is creating problems, I'd rather go back to the common pool.
FYI, this class will be deprecated for removal after the deprecation of
OAuth2 manager v1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
