ebyhr commented on code in PR #18793: URL: https://github.com/apache/iceberg/pull/18793#discussion_r4477526226
########## site/docs/benchmarks.md: ########## @@ -128,5 +129,5 @@ column used in the filter predicate. The performance is compared to the built-in `./gradlew -DsparkVersions=4.1 -DscalaVersion=2.13 :iceberg-spark:iceberg-spark-4.1_2.13:jmh -PjmhIncludeRegex=IcebergSourceNestedParquetDataFilterBenchmark -PjmhOutputPath=benchmark/iceberg-source-nested-parquet-data-filter-benchmark-result.txt` ### SparkParquetWritersNestedDataBenchmark -* A benchmark that evaluates the performance of writing nested Parquet data using Iceberg and Spark Parquet writers. To run this benchmark for either spark-2 or spark-3: +A benchmark that evaluates the performance of writing nested Parquet data using Iceberg and Spark Parquet writers. To run this benchmark for either spark-2 or spark-3: `./gradlew -DsparkVersions=4.1 -DscalaVersion=2.13 :iceberg-spark:iceberg-spark-4.1_2.13:jmh -PjmhIncludeRegex=SparkParquetWritersNestedDataBenchmark -PjmhOutputPath=benchmark/spark-parquet-writers-nested-data-benchmark-result.txt` Review Comment: Could you add an empty line between L132-133, and remove leading spaces? <img width="842" height="198" alt="Image" src="https://github.com/user-attachments/assets/160c811b-991f-46a6-aee6-2ee54895a4b9"; /> ↓ <img width="825" height="211" alt="Image" src="https://github.com/user-attachments/assets/11569ba6-69e1-4c8b-9c46-606e88e7b18e"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
