wombatu-kun commented on code in PR #18800:
URL: https://github.com/apache/iceberg/pull/18800#discussion_r4477241057
##########
core/src/test/java/org/apache/iceberg/TestInternalData.java:
##########
@@ -174,6 +178,48 @@ public void
registerToleratesExceptionInInitializerErrorOnInvoke() {
assertThatNoException().isThrownBy(() ->
register(ThrowsInitErrorOnInvoke.class.getName()));
}
+ @Test
+ void registersParquetWhenTheContextClassLoaderCannotSeeIceberg() throws
Exception {
Review Comment:
nit: the fix is in `register(String)`, so calling it reflectively as the
`registerTolerates*` tests do, with the current thread's context class loader
set to null in a try/finally and a registrar that records the call, would catch
this without a second copy of the classpath, the extra thread or
`TestHelpers.testClasspath()`. The `FormatModelRegistry` case could then live
next to its `register(String)` tests in `TestFormatModelRegistry` rather than
in the TCK binding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
