hcrosse commented on code in PR #3623:
URL: https://github.com/apache/iceberg-rust/pull/3623#discussion_r4468179594
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -644,15 +646,14 @@ impl ArrowSchemaVisitor for ArrowSchemaConverter {
DataType::Time64(unit) if unit == &TimeUnit::Microsecond => {
Ok(Type::Primitive(PrimitiveType::Time))
}
- DataType::Timestamp(unit, None) if unit == &TimeUnit::Microsecond
=> {
+ DataType::Timestamp(TimeUnit::Millisecond | TimeUnit::Microsecond,
None) => {
Ok(Type::Primitive(PrimitiveType::Timestamp))
Review Comment:
A millisecond column under a `timestamp_ns` or `timestamptz_ns` field now
fails to project with the same `Unsupported Arrow data type` error as on main,
instead of reading as nulls. The check runs on the projected field-ID columns
before the compatibility check, so optional columns are covered. A new test
reads an optional millisecond column under both nanosecond types and expects
the error, and under `timestamp` expects it to project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
