smaheshwar-pltr commented on PR #13225: URL: https://github.com/apache/iceberg/pull/13225#issuecomment-6643863317
Hey just catching back up here, I did have a few other patches and in the process, I did find some stuff that I'll need to fix in this PR: - An encrypted table's FileIO wraps the catalog's shared FileIO, so the catalog mistakes it for a table-specific one and closes it when the table is garbage collected (via file IO tracking) - Realised in https://github.com/apache/iceberg/pull/18799 that setting `encryption.key-id` *inside* a create transaction instead of up front writes plaintext files and then commits the table as unencrypted which differs to Hive. If we proceed with that PR first though, it'll be fixed by that shared state -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
