wirybeaver commented on code in PR #3342:
URL: https://github.com/apache/iceberg-rust/pull/3342#discussion_r4462066927
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -364,13 +443,22 @@ impl MinMaxColAggregator {
// Ignore the field if it is not in schema.
return Ok(());
};
- let Type::Primitive(ty) = ty.clone() else {
+ let Type::Primitive(ty) = ty else {
return Err(Error::new(
ErrorKind::Unexpected,
format!("Composed type {ty} is not supported for min max
aggregation."),
));
};
+ if matches!(ty, PrimitiveType::Geometry(_) |
PrimitiveType::Geography(_)) {
Review Comment:
Agreed on keeping the scope to Geometry. after fix,
- only Geometry consumes Parquet bounding boxes
- Geography returns without producing lower/upper bounds, even when its
column metadata includes geo_statistics.
- Removed the geography union/normalization path and added a regression test
for that omission.
- Geography payload and logical metadata writing remain covered by the
Parquet round-trip test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
