zeroshade commented on code in PR #2422:
URL: https://github.com/apache/iceberg-go/pull/2422#discussion_r4470917204
##########
table/transaction_delete.go:
##########
@@ -954,12 +954,29 @@ func (t *Transaction)
makePositionDeleteRecordsForFilter(ctx context.Context, fs
return nil, err
}
+ // Rows that existing position deletes already removed must not be
deleted
+ // again, so each task carries its file's position delete files from
scan
+ // planning, which matches them by sequence number, partition and path.
+ scan, err := t.Scan(WithRowFilter(filter),
WithCaseSensitive(caseSensitive))
Review Comment:
Without `WithSnapshotID`, this plans `main`'s current snapshot rather than
the transaction's branch head that `files` came from, so on a branch
transaction `main`'s position deletes are applied and rows the branch still has
are skipped. Please pin it to `t.planningSnapshot(meta)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
