rajendrag commented on code in PR #18673:
URL: https://github.com/apache/iceberg/pull/18673#discussion_r4463697148
##########
api/src/test/java/org/apache/iceberg/transforms/TestResiduals.java:
##########
@@ -49,6 +49,25 @@
import org.junit.jupiter.api.Test;
public class TestResiduals {
+ @Test
+ void lessThanKeepsNullDatePartition() {
+ Schema schema = new Schema(Types.NestedField.optional(1, "d",
Types.DateType.get()));
+ PartitionSpec spec =
PartitionSpec.builderFor(schema).identity("d").build();
+ ResidualEvaluator evaluator = ResidualEvaluator.of(spec, lessThan("d",
"2026-10-27"), true);
+
+ assertThat(evaluator.residualFor(Row.of((Object)
null))).isEqualTo(alwaysFalse());
Review Comment:
Added additional test `lessThanKeepsNullDayPartition`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
