slachiewicz commented on code in PR #18779:
URL: https://github.com/apache/iceberg/pull/18779#discussion_r4460880381
##########
core/src/test/java/org/apache/iceberg/TestFindFiles.java:
##########
@@ -138,7 +138,10 @@ public void testAsOfTimestamp() {
table.newAppend().appendFile(FILE_B).commit();
- long timestamp = System.currentTimeMillis();
+ // Strictly between FILE_B's and FILE_C's snapshots: in the same
millisecond as either, asOfTime
+ // would include FILE_C or drop FILE_B.
+ long timestamp =
TestHelpers.waitUntilAfter(table.currentSnapshot().timestampMillis());
+ TestHelpers.waitUntilAfter(timestamp);
Review Comment:
Applied in
[`0c1ba7e`](https://github.com/apache/iceberg/pull/18779/commits/0c1ba7ece07ca3d88c8669ef21bfca5162c2971d),
thanks: `asOfTime` includes a snapshot at the timestamp, so a single wait past
FILE_B's snapshot is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
