szehon-ho opened a new pull request, #3615: URL: https://github.com/apache/iceberg-rust/pull/3615
## Which issue does this PR close? Follow-up optimization identified while reviewing #3580; no separate issue. ## What changes are included in this PR? Removing K snapshot IDs from a table with N snapshots currently scans the snapshot map and searches the input slice for each entry. Remove each requested ID directly from the map, reducing selection and removal to expected O(K) hash-table operations without allocating a membership set. Only successful removals are recorded, so duplicate and missing IDs are omitted. The recorded IDs now follow their first occurrence in the request rather than hash-map iteration order. ## Are these changes tested? All 55 metadata-builder unit tests pass, including new coverage for duplicate and missing IDs, empty requests, retained snapshots, and snapshot-log cleanup. Formatting and whitespace checks pass. ## AI Disclosure Implemented with Codex. Please review the removal-update ordering change. The complexity improvement applies to the snapshot-removal loop; ref cleanup and snapshot-log processing still scan their respective collections. No end-to-end performance benchmark was run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
