danielcweeks commented on code in PR #18754: URL: https://github.com/apache/iceberg/pull/18754#discussion_r4459485772
########## core/src/main/java/org/apache/iceberg/rest/auth/BearerAuthManager.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.auth; + +import com.github.benmanes.caffeine.cache.Cache; +import com.github.benmanes.caffeine.cache.Caffeine; +import java.time.Duration; +import java.util.Map; +import org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting; +import org.apache.iceberg.rest.RESTClient; + +/** + * An auth manager that sets an {@code Authorization: Bearer} header on outgoing HTTP requests, as + * defined in RFC 6750. + * + * <p>The token is either read from a local file, which is re-read periodically, or provided + * statically in the configuration. Obtaining and renewing the token is the responsibility of an + * external process: this manager never contacts an authorization server. + */ +public final class BearerAuthManager implements AuthManager { + + /** + * Cache for standalone sessions created by {@link #tableSession(RESTClient, Map)}. Sessions hold + * no resources: entries only expire to prevent excessive memory usage, and cache maintenance runs + * on the calling thread rather than in a dedicated thread pool. + */ + private final Cache<BearerAuthConfig, BearerAuthSession> sessionCache = + Caffeine.newBuilder().expireAfterAccess(Duration.ofHours(1)).executor(Runnable::run).build(); + + public BearerAuthManager(String ignored) {} Review Comment: Why do we have this constructor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
