gty404 commented on code in PR #1082: URL: https://github.com/apache/iceberg-cpp/pull/1082#discussion_r4450405471
########## cmake_modules/IcebergThirdpartyToolchain.cmake: ########## @@ -490,20 +491,25 @@ function(resolve_croaring_dependency) set(ENABLE_ROARING_TESTS OFF) set(ENABLE_ROARING_MICROBENCHMARKS OFF) + # GitHub's auto-generated tag-archive tarball is not byte-stable across Review Comment: Hit it in this PR's own CI, not hypothetical: https://github.com/apache/iceberg-cpp/actions/runs/41434821884/job/125242025243 — the v4.7.1 tarball failed URL_HASH 6 times in a row with 6 different checksums, then `Each download failed!`. Reproduced manually too: fetched `https://github.com/RoaringBitmap/CRoaring/archive/refs/tags/v4.7.1.tar.gz` 3x plus once via `codeload.github.com` directly — 4 different SHA256 each time, none matching what I'd pinned. GitHub's tag-archive endpoint just isn't byte-stable across requests; only uploaded release assets (like nlohmann_json's) are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
