prabhleen2317 opened a new pull request, #4263: URL: https://github.com/apache/iceberg-python/pull/4263
`x in d.keys()` and `reversed(d.keys())` are equivalent to operating on the dict directly, so the `.keys()` calls are redundant and allocate a throwaway dict-view. - `pyiceberg/catalog/dynamodb.py`: `prop not in table_dict.keys()` → `prop not in table_dict` - `pyiceberg/table/update/snapshot.py`: `reversed(groups.keys())` → `reversed(groups)` Both are behavior-preserving: membership and reverse-iteration over a dict operate on its keys, in the same order. No code or tests relied on the removed `.keys()` calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
