rdblue commented on code in PR #16777:
URL: https://github.com/apache/iceberg/pull/16777#discussion_r4447464243
##########
format/spec.md:
##########
@@ -2032,7 +2041,7 @@ Types are serialized according to this table:
The schema JSON type strings in this table are the canonical serialized forms.
Readers should accept optional whitespace around parameters and separators in
parameterized type strings.
-Note that default values are serialized using the JSON single-value
serialization in [Appendix D](#appendix-d-single-value-serialization).
+Note that constant default values are serialized using the JSON single-value
serialization in [Appendix D](#appendix-d-single-value-serialization). Starting
in v4, a `write-default` that is a value expression is serialized using the
value expression JSON serialization defined in the [expressions
spec](expressions-spec.md#appendix-b-json-serialization).
Review Comment:
Minor: Should we add a note that the `{"type": "literal", "value": ...}`
form is preferred for constants?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
