AMBRA7592 commented on PR #4212: URL: https://github.com/apache/iceberg-python/pull/4212#issuecomment-6560507943
Thanks Alex. Updated the check to use the retained snapshot IDs, computed once before the loop. Added coverage for snapshots already absent from the table, including when no additional snapshots are expired. Removed the clock monkeypatches too. The catalog tests still exercise real commits and reloads; timestamp-boundary checks now use explicit metadata. I also split the scenario table into named tests with shared setup. Locally, all 4,517 unit tests passed, with 5 skipped, and `make lint` passed. The six new regression cases fail against the previous revision and pass with this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
