dragonknightk commented on PR #4205: URL: https://github.com/apache/iceberg-python/pull/4205#issuecomment-6538668102
> Looks pretty straight forward. There's some follow-ups (stale writer can create duplicate schema IDs). Thanks a lot! Thanks for the review (´｡• ᵕ •｡`) And thanks for flagging the stale writer case — you're right that it's still open, a rename that gets reverted doesn't move the last assigned field id, so the next schema id can still collide. That one comes from where the next schema id is picked rather than from the assertion added here, so I've left it out of this PR to keep the change small. Will keep an eye on it separately ʕ•ᴥ•ʔ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
