rdblue commented on code in PR #18704:
URL: https://github.com/apache/iceberg/pull/18704#discussion_r4428680268
##########
core/src/main/java/org/apache/iceberg/mumbling/MumblingBitmap.java:
##########
@@ -54,7 +55,7 @@ class MumblingBitmap implements ManifestBitmap {
private static final int MAX_CONTAINER_COUNT = 8_192;
private static final int MAX_CARDINALITY = 2_097_152;
- static MutableBitmap newMutableBitmap() {
+ static Mutable newMutableBitmap() {
Review Comment:
Good question and probably something to revisit before committing. I made
this change before exposing `merge` on `MutableBitmap`. The idea was that since
we know what the mutable class will be, we can return the more specific type
directly. Callers can pass that bitmap on as `MutableBitmap` but we want to
return the more specific type since it can have additional methods that aren't
part of the public API, like an accessor for container count.
After adding `merge` to `MutableBitmap`, we could choose to roll it back but
it does provide access `descriptorArray()` that is validated in tests. I left
it as is because I thought that it could be useful to expose more information
about the bitmap in the package but not necessarily in the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
