gaborkaszab commented on code in PR #17843:
URL: https://github.com/apache/iceberg/pull/17843#discussion_r4422140000
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1450,11 +1450,14 @@ private Builder
rewriteSnapshotsInternal(Collection<Long> idsToRemove, boolean s
long snapshotId = snapshot.snapshotId();
if (idsToRemove.contains(snapshotId)) {
snapshotsById.remove(snapshotId);
- if (!suppress) {
+ if (suppress) {
+ statisticsFiles.remove(snapshotId);
Review Comment:
I'm not entirely sure we want to remove the stats from table metadata when
suppressing snapshots. When we do load the rest of the snapshots, we don't load
their stats. Catalogs might still send the stats for suppressed snapshots too,
not sure we save much in case we remove them here since they are basically a
path and some extra metadata fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
