anoopj commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4419099168
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -99,6 +99,13 @@ default String location() {
/** Returns if collected, map from column ID to value upper bounds, null
otherwise. */
Map<Integer, ByteBuffer> upperBounds();
+ /**
+ * Returns whether the file's stats are tight, or null if unknown.
+ */
+ default Boolean tightStats() {
Review Comment:
> TLDR, conceptually I think this API here makes sense
Thanks for the confirmation!
> My only other comment here is why not just use primitive boolean and
return false by default?
My thinking was that the `ContentFile` should faithfully return what is
stored, and it should be the caller's responsibility to interpret the null
value. I am open to changing it if doing this inside `ContentFile` is the safer
choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
