Revanth14 commented on code in PR #2355:
URL: https://github.com/apache/iceberg-go/pull/2355#discussion_r4415671679
##########
exprs.go:
##########
@@ -769,6 +769,29 @@ func (ul *unboundLiteralPredicate) Bind(schema *Schema,
caseSensitive bool) (Boo
return nil, err
}
+ // A finite literal beyond the range of a floating-point term lies
between
+ // the largest finite value and infinity, so an ordering comparison
against
+ // it is the same as one against the largest finite value. Folding it to
+ // AlwaysTrue or AlwaysFalse instead would get NaN, the infinities and
NULL
+ // wrong: x < 1e100 on a float32 column is false for NaN and +Inf and
NULL
+ // for NULL.
+ if isFloatingPoint(bound.Type()) && isOrderingOp(ul.op) {
Review Comment:
Filed apache/iceberg#18700 and linked it in this comment and in the release
note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
