plusplusjiajia commented on PR #2651: URL: https://github.com/apache/iceberg-rust/pull/2651#issuecomment-6461461106
Thanks @blackmwk, reworked as you suggested. The vended credentials now go into `StorageConfig` as `StorageCredential`s, and both OpenDAL factories build one storage per credential prefix when they create the storage (`crates/storage/opendal/src/prefixed.rs`). `FileIO` is unchanged. I also took the `Transaction` change out of this PR and will send it separately. cc @zakariya-s: `StorageCredential` here has the same shape as the one in #2976, so whichever lands first, the other only needs to drop its copy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
