wirybeaver commented on code in PR #3341: URL: https://github.com/apache/iceberg-rust/pull/3341#discussion_r4395924482
########## crates/iceberg/src/arrow/value.rs: ########## Review Comment: Yes. The WKB extension and schema conversion already accept BinaryView, but the value converter was missing that array representation. Fixed in f6845967 by handling BinaryViewArray in the shared Binary/Geometry/Geography conversion branch. Added a regression test through arrow_primitive_to_literal using a real WKB point (stored outside the inline view) and a NULL, verifying payload and null preservation. The test failed before the fix and passes afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
