laskoviymishka commented on issue #2044: URL: https://github.com/apache/iceberg-go/issues/2044#issuecomment-6454262911
Thanks for offering, this fits, unless @slachiewicz already has something going. It's additive, so it doesn't gate v1, but having `catalogtest` run in plain `go test` while the pre-v1 refactors land is exactly the coverage I'd want, so sooner is better. `catalog/rest/resttest` and the first-PR scope look right to me. Two things for the v1 surface, since whatever this exports gets frozen with the rest of the module. I'd keep the exported API to the constructors plus options (`NewHandler(opts...)`, `NewServer(t, opts...)`), so later endpoints like views or credential vending stay additive. And I'd avoid exporting new wire types from `catalog/rest` to make it work: the table and view request/response structs are unexported today, and `catalog/rest/internal/planfake` is the nearest precedent for sharing test plumbing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
