kevinjqliu commented on code in PR #3554:
URL: https://github.com/apache/iceberg-rust/pull/3554#discussion_r4389920560
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -92,7 +92,7 @@ jobs:
with:
key: bindings-python
save-if: ${{ github.event_name == 'push' && github.ref ==
'refs/heads/main' }}
- - uses: $/.github/actions/generate-python-license
+ - uses: ./.github/actions/generate-python-license
Review Comment:
> We use the 0.11.x convention on GitHub Actions composite actions as we've
not updated Zizmor here.
👍
##########
bindings/python/about.toml:
##########
@@ -37,13 +37,14 @@ accepted = [
"BSD-2-Clause",
"BSL-1.0",
"CDLA-Permissive-2.0",
+ "bzip2-1.0.6",
]
ignore-build-dependencies = true
ignore-dev-dependencies = true
# The wheel targets in release_python.yml and release_python_nightly.yml. Keep
in sync.
+# 0.11.x branch builds no windows-arm wheel, so aarch64-pc-windows-msvc is
absent.
Review Comment:
👍
https://github.com/apache/iceberg-rust/blob/0.11.x/.github/workflows/release_python_nightly.yml#L77-L87
vs
https://github.com/apache/iceberg-rust/blob/340b6fa0d1e44fbcfdac68174298519e35819e47/.github/workflows/release_python_nightly.yml#L81-L93
(latest main)
##########
bindings/python/about.toml:
##########
@@ -82,3 +83,19 @@ path = "LICENSE.BSD-3-Clause"
checksum = "7055266497633c9025b777c78eb7235af13922117480ed5c674677adc381c9d8"
license = "BSD-3-Clause"
path = "zstd/LICENSE"
+
+# aws-lc-sys ships under a series of licenses. However, the licenses are
included as one file.
+# For simplicity, we just point each license at the same file at the cost of
duplicating the license text.
+[aws-lc-sys.clarify]
+license = "Apache-2.0 AND ISC AND MIT AND BSD-3-Clause"
+[[aws-lc-sys.clarify.files]]
+checksum = "728536b4160e051f86d7c9c388f704866b3d512cd7df97ac3516c65279523c4e"
+path = "LICENSE"
+
+# For individual crate acceptions, refer to deny.toml.
+
+[colored]
+accepted = ["MPL-2.0"]
+
+[option-ext]
+accepted = ["MPL-2.0"]
Review Comment:
these match
https://github.com/apache/iceberg-rust/blob/72573537e25ad85fb13df8bcc716fc742d265613/deny.toml#L37-L43
and this statement applies here too
> The MPL license is allowed (binary-only):
##########
bindings/python/about.toml:
##########
@@ -82,3 +83,19 @@ path = "LICENSE.BSD-3-Clause"
checksum = "7055266497633c9025b777c78eb7235af13922117480ed5c674677adc381c9d8"
license = "BSD-3-Clause"
path = "zstd/LICENSE"
+
+# aws-lc-sys ships under a series of licenses. However, the licenses are
included as one file.
+# For simplicity, we just point each license at the same file at the cost of
duplicating the license text.
+[aws-lc-sys.clarify]
+license = "Apache-2.0 AND ISC AND MIT AND BSD-3-Clause"
+[[aws-lc-sys.clarify.files]]
+checksum = "728536b4160e051f86d7c9c388f704866b3d512cd7df97ac3516c65279523c4e"
+path = "LICENSE"
Review Comment:
i noticed this isnt on main, is this something we need to add to main too?
##########
bindings/python/about.toml:
##########
@@ -37,13 +37,14 @@ accepted = [
"BSD-2-Clause",
"BSL-1.0",
"CDLA-Permissive-2.0",
+ "bzip2-1.0.6",
Review Comment:
verified that bzip2 is in
https://github.com/apache/iceberg-rust/blob/0.11.x/Cargo.lock but not in latest
main
https://github.com/apache/iceberg-rust/blob/340b6fa0d1e44fbcfdac68174298519e35819e47/Cargo.lock
but why this this in the `accepted` license?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
