blackmwk commented on code in PR #3106:
URL: https://github.com/apache/iceberg-rust/pull/3106#discussion_r4387259071
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -181,72 +184,107 @@ impl RestCatalogBuilder {
}
}
-/// Rest catalog configuration.
-#[derive(Clone, TypedBuilder)]
-pub(crate) struct RestCatalogConfig {
- #[builder(default, setter(strip_option))]
- name: Option<String>,
-
- uri: String,
-
- #[builder(default, setter(strip_option(fallback = warehouse_opt)))]
+/// Typed REST catalog properties.
+#[derive(Clone, Properties, PartialEq, Eq)]
+pub(crate) struct RestCatalogProperties {
+ #[property(key = REST_CATALOG_PROP_URI, default = "")]
+ pub(crate) uri: String,
Review Comment:
No, Add getter attr option to generate pub geter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
