deniskuzZ commented on PR #18518: URL: https://github.com/apache/iceberg/pull/18518#issuecomment-6440288567
> > #15384 has the same parseBounds fix and has been open for a bit now. Since this one is smaller and decodes through Conversions like every other bound, it may be simplest to land it and rebase on top, keeping its PathUtil/binding work. @qlong does that work for you? > > @nssalian @deniskuzZ I think it makes sense to land this one first without waiting for #15384. That would make mine a more focused PR. > > One gap: ExpressionUtil.unbind does not handle BoundExtract in this PR. Either add the 3-line fix now, or ship this one as it is and #15384 would fix it later. I tried the unbind branch on this PR, but on main it can't round-trip: BoundExtract.path() is normalized to $['event_id'], and PathUtil.parse still rejects brackets (Unsupported path, contains bracket). sanitize(struct, …) catches that and falls back to the unbound filter, so scan planning works without it. It depends on your bracket parsing, so I'd leave it to #15384. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
