badalprasadsingh commented on issue #2160: URL: https://github.com/apache/iceberg-go/issues/2160#issuecomment-6437368018
good to go @nirajan1111 :) but don't reuse the scan planning: it prunes by the row filter: delete on id = 1 is lost for filter id = 2, better: - prune by affected files, including dropped ones (their dvs) - always read unpartitioned delete manifests (global deletes) - careful with `classifyLiveDeletes`: mor shares it, and a missed dv there would mean two dvs for one file happy to review once the pr is raised -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
