rdblue commented on code in PR #18604:
URL: https://github.com/apache/iceberg/pull/18604#discussion_r4383853792
##########
core/src/main/java/org/apache/iceberg/StatsUtil.java:
##########
@@ -325,4 +336,181 @@ private static boolean isScalar(Schema schema,
Map<Integer, Integer> parentIndex
return true;
}
+
+ /** Inclusive source column bounds for a partition value. Upper is null when
unbounded. */
Review Comment:
I think we should have a better definition here. These are actually bounds
(not a specific value range) for a couple of reasons. First, the upper bound
for string truncation has to be outside of the range because it has to be
greater than all possible strings that can be truncated to the value. Second,
the timestamp partition problem means that those lower bounds include potential
values that are outside of the normal range. It would be good to document the
guarantees here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
