jopdorp commented on code in PR #3432:
URL: https://github.com/apache/iceberg-rust/pull/3432#discussion_r4377576498
##########
crates/iceberg/src/spec/values/datum.rs:
##########
@@ -330,6 +334,8 @@ impl Display for Datum {
) => {
write!(f, "{}", decimal_from_i128_with_scale(*val, *scale))
}
+ // The scale lives on the dropped source type, so only the
unscaled value is left.
+ (PrimitiveType::Unknown, PrimitiveLiteral::Int128(val)) =>
write!(f, "{val}"),
Review Comment:
One more in 00309a05f: with the older schema picked, a sibling source
promoted int to long could pair a long literal with an int type and hit the
`unreachable!()`, so the int and long arms now print across the promotion
either way. The test covers it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
