badalprasadsingh commented on code in PR #2332:
URL: https://github.com/apache/iceberg-go/pull/2332#discussion_r4376562022
##########
website/src/releases.md:
##########
@@ -50,7 +50,7 @@ Per-release notes (highlights, breaking changes,
contributors) are published on
- **Substrait expression conversion no longer takes case sensitivity.**
`substrait.ConvertExpr(schema, expression, caseSensitive)` becomes
`substrait.ConvertExpr(schema, expression)`. Case sensitivity remains part of
expression binding.
- **Transform formatting requires the result type.**
`Transform.ToHumanStr(value)` is removed. Use
`Transform.ToHumanStrType(resultType, value)` to format partition values,
including timestamps with time zones.
-- **Catalogs now require cleanup.** The `catalog.Catalog` interface includes
`Close() error`. Custom catalog implementations must provide `Close`, and
callers should close catalog instances after use. `catalog.Closer` remains
available as an alias for `io.Closer`.
+- **Catalogs now require cleanup.** The `catalog.Catalog` interface includes
`Close() error`. Custom catalog implementations must provide `Close`, and
callers should close catalog instances after use. `catalog.Closer` is removed;
use `io.Closer` instead.
Review Comment:
nit: can we mention something like this here:
```md
`catalog.Closer` is removed. Replace `cat.(catalog.Closer)` checks with
`defer cat.Close()`; use `io.Closer` anywhere else.
```
As, v0.7.0 docs told callers to write:
```go
if closer, ok := cat.(catalog.Closer); ok {
defer closer.Close()
}
```
So this is the code most people upgrading will have. "Use `io.Closer`
instead" points them to `cat.(io.Closer)`, which is now redundant because every
Catalog has Close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
