zakariya-s commented on code in PR #2976:
URL: https://github.com/apache/iceberg-rust/pull/2976#discussion_r4376588190
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -696,17 +888,26 @@ impl Storage for OpenDalStorage {
}
async fn delete_stream(&self, mut paths: BoxStream<'static, String>) ->
Result<()> {
- let mut deleters: HashMap<String, opendal::Deleter> = HashMap::new();
+ let mut deleters: HashMap<DeleteBatchKey, opendal::Deleter> =
HashMap::new();
while let Some(path) = paths.next().await {
- let bucket = self.batch_key_for_path(&path);
+ let batch_key = self.delete_batch_key_for_path(&path).await?;
Review Comment:
added `test_delete_stream_loads_a_credential_per_path_and_batch`, i'm not
sure whether we should skip the call as `S3FileIO.deleteFiles` also does [an
in-memory longest prefix lookup for every
path](https://github.com/apache/iceberg/blob/47677abf352f2e5c373cf82704ea7f2e675f8862/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java#L167).
since we require providers to cache, this is effectively the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
