mxm commented on code in PR #18610:
URL: https://github.com/apache/iceberg/pull/18610#discussion_r4375310745
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertReader.java:
##########
@@ -102,6 +107,8 @@ public void open(OpenContext openContext) throws Exception {
"Equality field IDs %s not present in table schema",
eqFieldIds);
fieldSerializer = new StructLikeSerializer();
+ dataKeyWrapper = new
InternalRecordWrapper(appendRowPosition(keySchema).asStruct());
Review Comment:
I think `keySchema` should suffice here:
```suggestion
dataKeyWrapper = new InternalRecordWrapper(keySchema.asStruct());
```
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertReader.java:
##########
@@ -102,6 +107,8 @@ public void open(OpenContext openContext) throws Exception {
"Equality field IDs %s not present in table schema",
eqFieldIds);
fieldSerializer = new StructLikeSerializer();
+ dataKeyWrapper = new
InternalRecordWrapper(appendRowPosition(keySchema).asStruct());
+ deleteKeyWrapper = new InternalRecordWrapper(keySchema.asStruct());
Review Comment:
One wrapper should be enough once they use the same schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
