swanandx commented on code in PR #3277:
URL: https://github.com/apache/iceberg-rust/pull/3277#discussion_r4367657554
##########
crates/iceberg/src/runtime/mod.rs:
##########
@@ -48,6 +55,29 @@ impl<T: Send + 'static> Future for JoinHandle<T> {
}
}
+/// A [`JoinHandle`] that aborts its task when dropped.
Review Comment:
reasoning already mentioned in PR decs, in prev reviews i wold told to not
repeat what's already there, hence not adding it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
