JeonDaehong commented on PR #3479: URL: https://github.com/apache/iceberg-rust/pull/3479#issuecomment-6378602363
@fm100 I ran your case through `RecordBatchTransformer`, which is what the equality delete loader uses (`delete_file_loader.rs`). The file columns are `[b#2=2, a#1=1]` and the projection is `[1, 2]`: | table schema | v0.10.1 | main (d2679a029) | this PR (8d8e1b603) | |---|---|---|---| | `[a#1, b#2]`, no rename | a=2, b=1 (wrong) | a=1, b=2 | a=1, b=2 | | `[x#1, y#2]`, renamed | x=2, y=1 (wrong) | x=2, y=1 (wrong) | x=1, y=2 | Your no-rename case is already fixed on main. #2746 (8b76dbef8) added a reorder check by name there, but that change isn't in any 0.10.x release. If the columns were renamed, it's still wrong on main, and this PR fixes that by matching field IDs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
