danielcweeks commented on code in PR #17389:
URL: https://github.com/apache/iceberg/pull/17389#discussion_r4363759842
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java:
##########
@@ -36,6 +37,18 @@ public interface AuthConfig {
@Value.Redacted
String token();
+ /** Path to a file containing a Bearer token, as an alternative to {@link
#token()}. */
+ @Nullable
+ @Value.Default
+ default String tokenPath() {
+ return null;
+ }
+
+ @Value.Default
+ default long tokenPathRefreshBufferMillis() {
Review Comment:
```suggestion
default long tokenPathRefreshMillis() {
```
I think we can remove the `Buffer`, which is a bit confusing. I think
everyone understand that it's refreshing from the path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
