David-Banquet commented on code in PR #4132:
URL: https://github.com/apache/iceberg-python/pull/4132#discussion_r4358892085
##########
mkdocs/docs/configuration.md:
##########
@@ -940,8 +944,8 @@ configures the AWS credentials for both Glue Catalog and S3
FileIO.
| client.secret-access-key | password | Configure the static secret
access key used to access both the Glue/DynamoDB Catalog and the S3 FileIO
|
| client.session-token | AQoDYXdzEJr... | Configure the static session
token used to access both the Glue/DynamoDB Catalog and the S3 FileIO
|
| client.profile-name | default | Configure the AWS profile used
to access both the Glue/DynamoDB Catalog and the S3 FileIO (only supported by
`FsspecFileIO` currently) |
-| client.role-session-name | session | An optional identifier for the
assumed role session.
|
-| client.role-arn | arn:aws:... | AWS Role ARN. If provided
instead of access_key and secret_key, temporary credentials will be fetched by
assuming this role. |
+| client.role-session-name | session | An optional identifier for the
assumed role session used to access both the Glue/DynamoDB Catalog and the S3
FileIO. |
+| client.role-arn | arn:aws:... | AWS Role ARN. If provided
instead of access_key and secret_key, temporary credentials will be fetched by
assuming this role before accessing both the Glue/DynamoDB Catalog and the S3
FileIO. |
Review Comment:
Thanks, done in ccd5aaa. The table now lists `client.assume-role.arn` first,
then `client.assume-role.session-name`.
`client.role-arn` and `client.role-session-name` already existed for the S3
FileIO, with `s3.role-arn` / `s3.role-session-name` as overrides, so I kept
them as a fallback. The catalogs and the S3 FileIO now read
`client.assume-role.*` first, then `client.role-*`. A catalog that passes the
Java keys covers both, and existing configs keep working. The `glue.role-*` and
`dynamodb.role-*` overrides follow the `s3.role-*` pattern.
Should the `client.role-*` keys also get a deprecation warning, or stay as
aliases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
