danielcweeks commented on code in PR #18254:
URL: https://github.com/apache/iceberg/pull/18254#discussion_r4361355169
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1439,6 +1429,59 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/sign/batch:
+ parameters:
+ - $ref: '#/components/parameters/prefix'
+ - $ref: '#/components/parameters/namespace'
+ - $ref: '#/components/parameters/table'
+ - $ref: '#/components/parameters/data-access'
+
+ post:
+ tags:
+ - Catalog API
+ summary: Remotely signs a batch of requests to object storage
+ operationId: batchSignRequests
+ description:
+ Signs a batch of requests to object storage on the client's behalf.
+
+
+ A server that supports this operation for a table MUST set
`sign-batch-max-size` in the
+ table's `RemoteSigningConfig`. A client MUST NOT send more elements
than that value. A
+ batch above the server's limit is rejected with 413.
Review Comment:
We're getting very heavy handed with the language here and I feel we're
being overly cautious about something that is rather obvious. I realize now
that OpenAPI has a way to define a default, so we should include reasonable
default here (I think you had 100) before. But just say that a client should
use the value provided in the RemoteSigningConfiguration.
We don't need to say things like "A client MUST NOT send more elements"
since it's configuration implies that and the server can enforce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
