adityaksolves commented on PR #18325: URL: https://github.com/apache/iceberg/pull/18325#issuecomment-6362179074
Rebased on the latest `main` (CI re-running now). @Fokko, @nastra could you please take a look when you get a chance? This allows `UnknownType` → primitive type promotion in `TypeUtil.isPromotionAllowed`, which fixes `ALTER TABLE ... ALTER COLUMN ... TYPE` failing on v3 `VOID` columns in Spark (#18305). The v3 spec allows `unknown` to be promoted to any primitive type. Tests added: `TestTypeUtil`, `TestSchemaUpdate`, and `TestAlterTable` for Spark 3.5/4.0/4.1/4.2. @manuzhang I noticed #16528 touches the same promotion rule. Happy to coordinate so we don't duplicate effort. Please let me know which one should move forward. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
