Sruhvx-jpg commented on PR #3165:
URL: https://github.com/apache/iceberg-rust/pull/3165#issuecomment-6367966137
- **In-Flight Task Drain Ordering**:
- `drain_and_abort()` calls `tasks.abort_all()` and joins `tasks` until
empty before invoking `upload.abort()`.
- Wired across all terminal arms: part failure, task panic, and
`complete()` failure in both `drain_capacity` and `close()`.
- Added `test_writer_part_failure_drains_siblings_before_abort` asserting
active tasks == 0 when `upload.abort()` runs.
- **Tokio Runtime Guard**:
- Added `check_tokio_runtime()` helper to guard `tasks.spawn` in
`flush_buffer` and `close()`, returning `ErrorKind::Unexpected` instead of
panicking outside Tokio. Reused in `Drop`.
- Added `test_runtime_guard_missing` and `test_runtime_guard_active`.
- **Multi-Part Integration Test & Stale Comments**:
- Configured `s3.multipart.part-size-bytes=5MiB` in
`test_file_io_s3_multipart_writer_past_threshold` so 12 MiB produces 3 genuine
parts (5 MiB, 5 MiB, 2 MiB) against MinIO.
- Removed stale 10 MiB `WriteMultipart` comments.
- **Empty Path Segments (`//`) Parity Gap**:
- Retained `ObjectStorePath::parse` to prevent double-encoding `%2F`.
- Documented the parity gap with Java `S3URI`/OpenDAL due to
`object_store::path::Path` POSIX invariants, annotated with upstream `arrow-rs`
TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
