mxm commented on code in PR #18330:
URL: https://github.com/apache/iceberg/pull/18330#discussion_r4350549493
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -284,6 +284,8 @@ private void replacePartitions(
CommitSummary summary = new CommitSummary();
summary.addAll(pendingResults);
+ Preconditions.checkState(
+ summary.deleteFilesCount() == 0, "Cannot overwrite partitions with
delete files.");
Review Comment:
Instead of checking here when it's too late, how about adding a check to
`DynamicWriter`?
https://github.com/apache/iceberg/blob/7461b5047638fe07285a175a3e113e73fc5e19de/flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java#L108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
