rambleraptor commented on code in PR #4133:
URL: https://github.com/apache/iceberg-python/pull/4133#discussion_r4353256641
##########
pyiceberg/catalog/glue.py:
##########
@@ -243,11 +248,14 @@ def _construct_table_input(
metadata: TableMetadata,
glue_table: Optional["TableTypeDef"] = None,
prev_metadata_location: str | None = None,
+ prev_metadata_properties: Properties | None = None,
) -> "TableInputTypeDef":
table_input: TableInputTypeDef = {
"Name": table_name,
"TableType": EXTERNAL_TABLE,
- "Parameters": _construct_parameters(metadata_location, glue_table,
prev_metadata_location, properties),
+ "Parameters": _construct_parameters(
+ metadata_location, glue_table, prev_metadata_location, properties,
prev_metadata_properties
Review Comment:
Can you use named parameters for this? We've got a lot of properties with
very similar names and ever so different orderings of parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
