rambleraptor commented on code in PR #4129:
URL: https://github.com/apache/iceberg-python/pull/4129#discussion_r4353170683
##########
tests/io/test_pyarrow.py:
##########
@@ -3579,6 +3579,33 @@ def test__to_requested_schema_null_map_of_structs() ->
None:
assert result.column(1).to_pylist() == [[], None, [("b", 2), ("c", None)]]
+def test__to_requested_schema_null_list_of_structs() -> None:
Review Comment:
Can you write a test that involves LargeListArray inputs? I'm pretty sure
this change causes a regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]