kevinjqliu commented on code in PR #3490:
URL: https://github.com/apache/iceberg-rust/pull/3490#discussion_r4350623771
##########
.github/workflows/ci.yml:
##########
@@ -217,7 +213,6 @@ jobs:
run: cargo build -p iceberg --no-default-features
tests:
- needs: lint
Review Comment:
Good call. I pulled numbers for the last 2 weeks. On PR CI, lint failed in
20 of 357 runs (5.6%), and skipping the dependent jobs saved ~590 runner-min,
about 5.6% of PR CI compute. In the merge queue, lint never failed across 79
runs, so there `needs: lint` only adds a second runner wait.
Dropping it only for the merge queue is doable, but `needs` can't depend on
the event. We'd have to skip `lint` on `merge_group`, add a second lint job for
it, add an `if` to every dependent job, and have `ci-required` accept the
skipped one. I reverted the `needs: lint` change to keep this PR to the merge
queue setting. Happy to do the split in a follow-up if you think it's worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
