fallintoplace opened a new pull request, #2270: URL: https://github.com/apache/iceberg-go/pull/2270
## What Reuse path prefixes while building nested schema name indexes. ## Why Wide nested schemas repeat the same ancestor string work for many fields. ## Implementation - Keep full and short prefixes during the schema walk. - Reuse the full name when both indexes need the same path. - Add nested, list alias, empty segment, and sibling cases. ## Benchmark Standalone 256-field visitor benchmark, Go 1.23.2, Linux/amd64, Xeon Platinum 8573C; median of 3 runs. | Index | Depth | ns/op before -> after | B/op before -> after | allocs/op before -> after | | --- | ---: | ---: | ---: | ---: | | IndexByName | 0 | 46,551 -> 46,726 | 30,789 -> 30,785 | 13 -> 13 | | IndexByName | 2 | 176,279 -> 102,820 | 84,579 -> 68,975 | 1,055 -> 289 | | IndexByName | 8 | 205,139 -> 117,964 | 136,739 -> 82,739 | 1,083 -> 304 | | IndexByName | 24 | 379,779 -> 147,331 | 294,746 -> 123,478 | 1,151 -> 328 | | IndexNameByID | 0 | 92,499 -> 88,737 | 61,524 -> 61,472 | 26 -> 25 | | IndexNameByID | 2 | 209,334 -> 123,510 | 115,314 -> 68,916 | 1,067 -> 285 | | IndexNameByID | 8 | 236,255 -> 113,398 | 167,480 -> 82,490 | 1,095 -> 296 | | IndexNameByID | 24 | 389,714 -> 146,901 | 325,482 -> 122,474 | 1,163 -> 316 | These are visitor benchmark results, not full application timings. Reproduce with `go test . -run '^$' -bench '^BenchmarkSchemaNameIndex' -benchmem -benchtime=1s -count=5 -cpu=1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
