gaborkaszab commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r4346566094
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -172,7 +172,8 @@ public void readDataFile(FileFormat format) throws
IOException {
DV,
null, // manifest info
ByteBuffer.wrap(new byte[] {1, 2, 3}), // key metadata
- ImmutableList.of(50L, 100L));
+ ImmutableList.of(50L, 100L),
+ null); // column files
Review Comment:
@RussellSpitzer @stevenzwu I've merged this PR with the `V4ManifestReader`
integration into this one. I've also created a PoC for the
`reader.transformField(...)` implementation. Seems feasible, but wouldn't say
it's trivial, so with the merge I went with the "afterthought" resolution
approach to be consistent with the current code. We can do the
`transformField()` in a follow-up.
Is this what you meant @RussellSpitzer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
